Skip to content

Add support for OneBox Environment, Fixes AB#3113751 #2559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shahzaibj merged 6 commits into from
Jan 8, 2025
Merged

Add support for OneBox Environment, Fixes AB#3113751 #2559

shahzaibj merged 6 commits into from
Jan 8, 2025

Conversation

@shahzaibj
Copy link
Contributor

@shahzaibj shahzaibj commented Dec 20, 2024 •
edited by azure-boards bot
Loading

Fixes AB#3113751

Changes to allow MSAL/Broker to talk to eSTS running locally. This basically does the following:

  • Add build config flag to bypass authority validation. This is required because local eSTS authorities are not discovered via cloud discovery. We can enable this flag locally in gradle project properties to target local eSTS.
  • Read the port number of the authority when constructing the cloud URL because targeting local eSTS requires supplying exact port. I've scoped the change to read port only when environment is specified as onebox.

Related MSAL PR: AzureAD/microsoft-authentication-library-for-android#2231

@shahzaibj shahzaibj self-assigned this Dec 20, 2024
@github-actions
Copy link

github-actions bot commented Dec 20, 2024

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

@shahzaibj shahzaibj mentioned this pull request Dec 20, 2024
Merged
@shahzaibj shahzaibj changed the title Add support to talk to local ests onebox deployment Add support for OneBox Environment Dec 20, 2024
@shahzaibj shahzaibj changed the title Add support for OneBox Environment Add support for OneBox Environment, Fixes AB#3113751 Dec 27, 2024
@shahzaibj shahzaibj changed the title Add support for OneBox Environment, Fixes AB#3113751 Add support for OneBox Environment., Fixes AB#3113751 Dec 27, 2024
@shahzaibj shahzaibj marked this pull request as ready for review December 27, 2024 17:07
@shahzaibj shahzaibj requested a review from a team as a code owner December 27, 2024 17:07
@shahzaibj shahzaibj changed the title Add support for OneBox Environment., Fixes AB#3113751 Add support for OneBox Environment Dec 30, 2024
@github-actions
Copy link

github-actions bot commented Dec 30, 2024

✅ Work item link check complete. Description contains link AB#3113751 to an Azure Boards work item.

@github-actions github-actions bot changed the title Add support for OneBox Environment Add support for OneBox Environment, Fixes AB#3113751 Dec 30, 2024
@shahzaibj shahzaibj requested a review from mohitc1 December 31, 2024 22:40
@shahzaibj shahzaibj merged commit c69eb7d into dev Jan 8, 2025
24 checks passed
shahzaibj added a commit to AzureAD/microsoft-authentication-library-for-android that referenced this pull request Jan 29, 2025
@shahzaibj
Add support for OneBox Environment, Fixes AB#3113751 (#2231)
b399544 
Fixes
[AB#3113751](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3113751)

Adds a new MSAL config file for the OneBox environment. This specifies
exact authority that onebox is using.

Related common PR:
AzureAD/microsoft-authentication-library-common-for-android#2559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mohitc1 mohitc1 mohitc1 approved these changes

@melissaahn melissaahn melissaahn approved these changes

Assignees

@shahzaibj shahzaibj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shahzaibj @mohitc1 @melissaahn